Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS#37081: Added OVN RN update #81666

Merged
merged 1 commit into from
Sep 18, 2024
Merged

OCPBUGS#37081: Added OVN RN update #81666

merged 1 commit into from
Sep 18, 2024

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Sep 12, 2024 •
edited
Loading

Version(s):
4.14

Issue:
OCPBUGS-37081

Link to docs preview:
4.14.0

  • SME has approved this change. (Riccardo Ravaioli)
  • QE has approved this change. (Anurag Saxena)

Additional information:

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Sep 12, 2024
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-37081, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-37081 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 12, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 12, 2024
@dfitzmau dfitzmau changed the title OCPBUGS-37081: Added OVN RN update OCPBUGS#37081: Added OVN RN update Sep 12, 2024
@openshift-ci-robot openshift-ci-robot removed jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 12, 2024
@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s):
4.14

Issue:
OCPBUGS-37081

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 12, 2024 •
edited
Loading

🤖 Tue Sep 17 10:43:17 - Prow CI generated the docs preview:

https://81666--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes.html

@dfitzmau dfitzmau force-pushed the OCPBUGS-37081 branch 3 times, most recently from 61b7b69 to 43de14a Compare September 12, 2024 11:53
@sreber84
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2024
ricky-rav
ricky-rav suggested changes Sep 12, 2024
View reviewed changes
Copy link

@ricky-rav ricky-rav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little type in the title, other than that all good! :)

release_notes/ocp-4-14-release-notes.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2024
@dfitzmau
Copy link
Contributor Author

/label peer-review-needed

ricky-rav
ricky-rav approved these changes Sep 12, 2024
View reviewed changes
Copy link

@ricky-rav ricky-rav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks, Darragh!

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 12, 2024
@ShaunaDiaz ShaunaDiaz added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 12, 2024
@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Sep 12, 2024
@ShaunaDiaz ShaunaDiaz added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2024
@anuragthehatter
Copy link

For 4.14.0 this looks good but we just backported changes allowing these values to be configurable https://issues.redhat.com/browse/OCPBUGS-41360

Now I am thinking we might need to mention them like those are configurable in 4.14z and 4.15 z as well.
@dfitzmau Not sure if you can help with that or someone already on it

Also good to mention IPv6 reserved range as well as more and more customers are now trying IPv6?
Equivalent IPv6 ranges can be referred from https://github.com/openshift/ovn-kubernetes/blob/master/contrib/kind.sh#L553

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 17, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anuragthehatter
Copy link

As discussed with @dfitzmau regarding z stream notes

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
@dfitzmau dfitzmau merged commit 8fab29d into openshift:enterprise-4.14 Sep 18, 2024
2 checks passed
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Oct 15, 2024
@wking
WIP: blocked-edges/4.14.*-OVNTransitSwitchSubset: Declare 4.13-to-4.1…
c068c19 
…4 risk

The risk is briefly covered in the linked release note since
2024-09-18 [1].

I'm setting autoExtend, because unless some future 4.13.z addresses
this (unlikely, with 4.13.z going end-of-life on 2014-11-27 [2]), or a
future 4.14.z addresses this, we'll likely have to continue to carry
it forward to every 4.13-to-4.14 update we ever support.  This will
make life more difficult for customers who traditionally wait until
there's an update we recommend unconditionally.  All OVN cluster
administrators on 4.13 will need to read through the risk message and
linked docs, and decide for themselves whether they are comfortable
accepting the risk and updating to 4.14.

Generated by writing the 4.14.0 risk by hand, and then copying out to
all existing 4.14.z update targets with:

  $ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.14&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]14[.][0-9]*$' | grep -v 4.14.0 | while read VERSION; do sed "s/4.14.0/${VERSION}/" blocked-edges/4.14.0-OVNTransitSwitchSubset.yaml > "blocked-edges/${VERSION}-OVNTransitSwitchSubset.yaml"; done

[1]: openshift/openshift-docs#81666 (comment)
[2]: https://access.redhat.com/support/policy/updates/openshift#dates
@wking wking mentioned this pull request Oct 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricky-rav ricky-rav ricky-rav approved these changes

Assignees

@sreber84 sreber84

@anuragthehatter anuragthehatter

Labels
lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
7 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @sreber84 @anuragthehatter @ricky-rav @ShaunaDiaz